fix: Return 200 in VCT health check if disabled or not yet configured #1384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1384 +/- ##
==========================================
+ Coverage 87.94% 87.96% +0.01%
==========================================
Files 205 205
Lines 19029 19047 +18
==========================================
+ Hits 16735 16754 +19
- Misses 1471 1472 +1
+ Partials 823 821 -2
Continue to review full report at Codecov.
|
fqutishat
approved these changes
Jun 27, 2022
If VCT is disabled or if the log endpoint has not yet been configured then the VCT health check does not cause the health check to fail, it simply returns the status of VCT. closes trustbloc#1360 Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If VCT is disabled or if the log endpoint has not yet been configured then the VCT health check does not cause the health check to fail, it simply returns the status of VCT.
closes #1360
Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com