separate lockfiles for example repos #3719

juliusmarminge · 2023-02-03T16:10:58Z

Closes #94

🎯 Changes

What changes are made in this PR? Is it a feature or a bug fix?

Runs installation with shared-workspace-lockfile=false
Commits this change (this commit is not visible on the parent repo (this one), only child)
Sync downstream using subtree

Tested here:

I guess the downside is that there will be a duplicate commit for the lockfile sync:

✅ Checklist

I have followed the steps listed in the Contributing guide.
If necessary, I have added documentation related to the changes made.
I have added or updated the tests related to the changes made.

vercel · 2023-02-03T16:11:05Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
next-prisma-starter	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 4, 2023 at 3:32PM (UTC)
og-image	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 4, 2023 at 3:32PM (UTC)

1 Ignored Deployment

Name	Status	Preview	Comments	Updated
www	⬜️ Ignored (Inspect)			Feb 4, 2023 at 3:32PM (UTC)

.github/workflows/subtree.yml

KATT

The trpc deps become relative so itdoesn't fully work, unfortunately, leading the CI to fail.

juliusmarminge · 2023-02-04T00:26:35Z

The trpc deps become relative so itdoesn't fully work, unfortunately, leading the CI to fail.

https://github.com/trpc/examples-next-prisma-starter/blob/ec7cdebd25f1a5c6f41e55a8de90fd5cfd17158d/pnpm-lock.yaml#L39-L42

https://github.com/trpc/examples-next-prisma-starter/tree/subtree-lockfiles

https://github.com/trpc/examples-next-prisma-starter/actions/runs/4088954745/jobs/7051147754

Uurgh... theres prob an option we can add here similar to the lockfile setting, https://pnpm.io/npmrc#link-workspace-packages

juliusmarminge · 2023-02-04T09:05:12Z

Made a solution that is slow and very hacky... it works... but I doubt it'll work in future versions of pnpm

Slow doesn't really matter here (activating the cache took it down to 3 mins so not that slow anymore), it's a job only done when pushes to main - not a CI job people have to sit and wait for every push they make and wanna see if CI passes.

What makes you think it won't work on future versions? tbh I'm a bit confused why it doesn't respect it just with the shared-lockfile option 🤔 Might be worth opening an issue to pnpm

.github/workflows/subtree.yml

separate lockfiles for example repos

c22ae09

juliusmarminge requested review from KATT, trpc-bot, sachinraja and bautistaaa as code owners February 3, 2023 16:10

juliusmarminge commented Feb 3, 2023

View reviewed changes

.github/workflows/subtree.yml Outdated Show resolved Hide resolved

remove unused cache

39cea88

vercel bot deployed to Preview – og-image February 3, 2023 16:21 View deployment

vercel bot deployed to Preview – todomvc February 3, 2023 16:22 View deployment

vercel bot deployed to Preview – next-prisma-starter February 3, 2023 16:22 View deployment

name

31b5f8a

vercel bot deployed to Preview – og-image February 3, 2023 16:26 View deployment

vercel bot deployed to Preview – todomvc February 3, 2023 16:26 View deployment

vercel bot deployed to Preview – next-prisma-starter February 3, 2023 16:26 View deployment

remove node matrix

3356871

vercel bot deployed to Preview – og-image February 3, 2023 16:30 View deployment

vercel bot deployed to Preview – todomvc February 3, 2023 16:30 View deployment

vercel bot deployed to Preview – next-prisma-starter February 3, 2023 16:31 View deployment

test

a71d95a

vercel bot deployed to Preview – og-image February 4, 2023 00:11 View deployment

vercel bot deployed to Preview – next-prisma-starter February 4, 2023 00:11 View deployment

vercel bot deployed to Preview – todomvc February 4, 2023 00:12 View deployment

test 2

c4c058b

vercel bot deployed to Preview – og-image February 4, 2023 00:16 View deployment

vercel bot deployed to Preview – next-prisma-starter February 4, 2023 00:16 View deployment

vercel bot deployed to Preview – todomvc February 4, 2023 00:16 View deployment

KATT previously requested changes Feb 4, 2023

View reviewed changes

test

c885783

vercel bot deployed to Preview – todomvc February 4, 2023 08:28 View deployment

vercel bot deployed to Preview – next-prisma-starter February 4, 2023 08:29 View deployment

Update .github/workflows/subtree.yml

2ec2062

vercel bot deployed to Preview – og-image February 4, 2023 09:03 View deployment

vercel bot deployed to Preview – todomvc February 4, 2023 09:03 View deployment

vercel bot deployed to Preview – next-prisma-starter February 4, 2023 09:03 View deployment

juliusmarminge commented Feb 4, 2023

View reviewed changes

.github/workflows/subtree.yml Show resolved Hide resolved

test filter

29de35d

vercel bot deployed to Preview – og-image February 4, 2023 09:09 View deployment

vercel bot deployed to Preview – todomvc February 4, 2023 09:10 View deployment

vercel bot deployed to Preview – next-prisma-starter February 4, 2023 09:10 View deployment

juliusmarminge commented Feb 4, 2023

View reviewed changes

.github/workflows/subtree.yml Outdated Show resolved Hide resolved

Update .github/workflows/subtree.yml

6166122

vercel bot deployed to Preview – og-image February 4, 2023 09:12 View deployment

vercel bot deployed to Preview – todomvc February 4, 2023 09:13 View deployment

vercel bot deployed to Preview – next-prisma-starter February 4, 2023 09:13 View deployment

filter didn't work

2ee4e30

vercel bot deployed to Preview – og-image February 4, 2023 09:15 View deployment

vercel bot deployed to Preview – todomvc February 4, 2023 09:15 View deployment

vercel bot deployed to Preview – next-prisma-starter February 4, 2023 09:15 View deployment

juliusmarminge requested a review from KATT February 4, 2023 09:18

cleanup test

4c7baf3

vercel bot deployed to Preview – og-image February 4, 2023 15:32 View deployment

vercel bot deployed to Preview – todomvc February 4, 2023 15:32 View deployment

vercel bot deployed to Preview – next-prisma-starter February 4, 2023 15:32 View deployment

bautistaaa approved these changes Feb 4, 2023

View reviewed changes

juliusmarminge merged commit 2d02328 into main Feb 4, 2023

juliusmarminge deleted the subtree-lockfiles branch February 4, 2023 16:02

github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

separate lockfiles for example repos #3719

separate lockfiles for example repos #3719

Uh oh!

juliusmarminge commented Feb 3, 2023 •

edited

Loading

Uh oh!

vercel bot commented Feb 3, 2023 •

edited

Loading

Uh oh!

Uh oh!

KATT left a comment •

edited

Loading

Uh oh!

juliusmarminge commented Feb 4, 2023

Uh oh!

juliusmarminge commented Feb 4, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

separate lockfiles for example repos #3719

separate lockfiles for example repos #3719

Uh oh!

Conversation

juliusmarminge commented Feb 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

Uh oh!

vercel bot commented Feb 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

KATT left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

juliusmarminge commented Feb 4, 2023

Uh oh!

juliusmarminge commented Feb 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

juliusmarminge commented Feb 3, 2023 •

edited

Loading

vercel bot commented Feb 3, 2023 •

edited

Loading

KATT left a comment •

edited

Loading

juliusmarminge commented Feb 4, 2023 •

edited

Loading