LTO breaks down linking OpenXLSX on some compilers #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi and thank you for your contribution! I have to admit this is the first time I even heard about link-time optimization, so I need to read up on it for a bit, but at a first glance I see no problem with accepting your pull request. I would ask you to give me a few days though because I would like to merge the development branch into master, then accept your pull request :) |
|
Ok, you are welcome ) |
|
merged into master today. https://github.com/troldal/OpenXLSX/commits/master/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link-Time Optimization (LTO) breaks down the build on some compilers and platforms when OpenXLSX is used as dependency shared library:
BuildLog.txt
I suggest to have an option in CMakeLists.txt to disable LTO.