UtilityFunction should not complain method that works inside an interator #681
Description
The UtilityFunction smell could be misleading, e.g.
# Just for Fun
class Fun
attr_accessor :arr
def bar
arr.each do |a_variable|
# This is an intermediate state, should not be communicated as
# an instance variable, as reek suggests
b_variable = process(a_variable)
puts b_variable
end
end
private
def process(x_variable)
x_variable + 1
end
endreek fun.rb
=> fun.rb -- 1 warning:
=> [16]:Fun#process doesn't depend on instance state (UtilityFunction)It is useful most of the time, but for method that process an intermediate state, create a instance variable is not the right way.