Case sensitive config (again) #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this removes the need to convert all keys to lowercase - if there is an unknwon config key, a suggestion will be given
msiebeneicher
approved these changes
Aug 15, 2017
core/pluginconfig.go
Outdated
|
|
||
| func (conf PluginConfig) suggestKey(searchKey string) string { | ||
| closestDist := len(searchKey) | ||
| bestMatch := "something else" |
There was a problem hiding this comment.
maybe better to use "no suggestion" or an empty string as default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this pull request
We saw a problem with the conversion from mixed case keys to lower case keys when parsing the configs. In a nutshell we cannot really distinguish between keys that can be case sensitive and those that are not (nested modulator arrays for example).
As of that and because of the fact that unknown config keys will stop gollum from starting we decided to make the config case sensitive again. In addition to that we will now display a suggestion for unknown keys, so that broken configs can be fixed faster.
Checklist
make testexecuted successfully