This repository was archived by the owner on May 28, 2019. It is now read-only.
SDIO: remove SDIO_IRQHandler and interrupt config #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #49
With these changes, the boardloader vector table is clean.
I've tested that the boardloader SDIO stuff works with this code removed. I was able to put a new bootloader on and install a firmware using that (Nice work! Those are changes from today that I haven't reviewed other than to run functional tests so far).
The bootloader already did not have this interrupt handler in its vector table.
That left the firmware as the only place that might use SDIO interrupts. Upon further inspection, I don't think we use SDIO interrupts anywhere, so I've removed the IRQ setup etc...