Improves namedtuple definition
#2501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am working on new `mypy` feature and it identified a problem with your `namedtuple` definitions. python/mypy#11206 (comment) By standard first string arg should match variable name.
|
|
ekilmer
approved these changes
Nov 8, 2021
There was a problem hiding this comment.
Is this related? https://github.com/trailofbits/manticore/runs/4143043177?check_suite_focus=true
It is not!
Thank you for the PR @sobolevn ! Good luck with getting your feature PR merged in mypy 😄
sobolevn
added a commit
to sobolevn/manticore
that referenced
this pull request
Dec 4, 2021
While working on python/mypy#11206 I found that `Regspec` definition is not ideal. It is recommended to use the same string name, as variable name. For example, it affects how `pickle` works. Related trailofbits#2501 Related trailofbits@6e036f3
ekilmer
pushed a commit
that referenced
this pull request
Dec 5, 2021
While working on python/mypy#11206 I found that `Regspec` definition is not ideal. It is recommended to use the same string name, as variable name. For example, it affects how `pickle` works. Related #2501 Related 6e036f3
ekilmer
added a commit
that referenced
this pull request
Mar 3, 2022
* master: (35 commits) Switch to stable Black (#2536) Fix typo in Manticore.linux constructor docstring (#2535) Revert CI changes made in #2526 Release Manticore 0.3.7 (#2526) Optimise forking when there is only 1 solution (#2527) Epoll Implementation (#2529) Split off ENDBR32/64 from CHESS branch (#2533) Update to crytic-compile 0.2.2 (#2530) Also ignore missing unicorn registers in the fallback emulator (#2531) x86 FXSAVE & FXRSTOR support (#2511) Fix `BitVecExtract` simplification for constant folding (#2524) Add pip-audit action workflow (#2513) Add EXPLICIT fork policy (#2514) Enforce crytic-compile==0.2.1 (#2512) Improve namedtuple definition (#2506) Add SMT simplifications for bitvec subtraction (#2504) Fix handling of the program base address in Linux (#2500) Bump Sphinx version to 4.3.0 (#2503) Solver Improvements (#2502) Improves `namedtuple` definition (#2501) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on new
mypyfeature and it identified a problem with yournamedtupledefinitions.python/mypy#11206 (comment)
By standard first string arg should match variable name.
Refs python/mypy#11206