Fix default output space when workspace is in mem: #1724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekilmer
requested changes
Jun 8, 2020
ekilmer
approved these changes
Jun 8, 2020
ehennenfent
reviewed
Jun 8, 2020
There was a problem hiding this comment.
Assuming the tests pass, this LGTM. I'm still confused as to how we got the error that we did. It should only be possible to reach the branch we end up in if the working directory doesn't already exist, and yet, we get an error because it does. I thought it might be a race condition in temp file creation, but the docs explicitly say that's not a problem: https://docs.python.org/3.6/library/tempfile.html#tempfile.mkdtemp
In any case, by correctly passing in a file name, hopefully we'll avoid that problem.
ehennenfent
approved these changes
Jun 8, 2020
ekilmer
added a commit
that referenced
this pull request
Jun 15, 2020
* master: Symbolic model for strcpy (#1681) Rollback to support yices again (#1714) Fix default output space when workspace is in mem: (#1724) VMTests tests for istanbul (#1676) Snapshots & is_main (#1710) Fix Black (#1718) Use CoverageRC, Make CodeCov Less Aggressive (#1705) Fix plugin enable/disable magic (#1708) Add a warning when selected no methods for inclusion (#1707) Remove duplicated entries (#1709) Blacken (#1711)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.