Skip to content

next release v4.47.0 #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jun 28, 2020
Merged

next release v4.47.0 #993

merged 22 commits into from
Jun 28, 2020

Conversation

casperdcl
Copy link
Member

@casperdcl casperdcl commented Jun 25, 2020



  • maybe add docs/images

image

@casperdcl casperdcl added p3-enhancement 🔥 Much new such feature question/docs ‽ Documentation clarification candidate labels Jun 25, 2020
@casperdcl casperdcl added this to the v5.0.0 milestone Jun 25, 2020
@casperdcl casperdcl requested a review from lrq3000 as a code owner June 25, 2020 19:21
@casperdcl casperdcl self-assigned this Jun 25, 2020
@casperdcl casperdcl added the to-merge ↰ Imminent label Jun 25, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2020

Codecov Report

Merging #993 into master will increase coverage by 0.26%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master     #993      +/-   ##
==========================================
+ Coverage   86.90%   87.16%   +0.26%     
==========================================
  Files          21       21              
  Lines        1260     1278      +18     
  Branches      215      217       +2     
==========================================
+ Hits         1095     1114      +19     
+ Misses        144      143       -1     
  Partials       21       21              

@casperdcl casperdcl added p1-bug-perf ⚡ Speed suboptimal submodule ⊂ Periphery/subclasses submodule-notebook 📓 Much web such IDE synchronisation ⇶ Multi-thread/processing labels Jun 26, 2020
casperdcl and others added 2 commits June 26, 2020 16:51
Would be required to extend queue len > 2
In tqdm.auto, look for `IPython` in `sys.modules` rather than
explicitly importing it. If we are in an IPython notebook, then
IPython will have already been imported. If we are not in an
IPython notebook, then importing IPython will take almost half a
second.

Here are import times on a 2018 MacBook Pro with an SSD.
Before this patch:

    $ time python -c 'from tqdm.auto import tqdm'

    real     0m0.474s
    user     0m0.278s
    sys      0m0.142s

After this patch:

    $ time python -c 'from tqdm.auto import tqdm'

    real    0m0.069s
    user    0m0.041s
    sys     0m0.020s

Fixes #709.
@casperdcl casperdcl added the p0-bug-critical ☢ Exception rasing label Jun 28, 2020
@casperdcl casperdcl merged commit 15c5c51 into master Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p0-bug-critical ☢ Exception rasing p1-bug-perf ⚡ Speed suboptimal p3-enhancement 🔥 Much new such feature question/docs ‽ Documentation clarification candidate submodule ⊂ Periphery/subclasses submodule-notebook 📓 Much web such IDE synchronisation ⇶ Multi-thread/processing to-merge ↰ Imminent
Projects
None yet
3 participants