Skip to content

Conversation

dwhswenson
Copy link
Contributor

Based on the documentation, the default value for file is None. However, if you explicitly provide that as tqdm_notebook(iterable, file=None), you get the "red block". This is a quick little fix for that.

Illustration of problem:
image

The changes here get rid of that red block.


  • I have visited the source website, and in particular
    read the known issues
  • I have searched through the issue tracker for duplicates
  • I have mentioned version numbers, operating system and
    environment, where applicable:
    import tqdm, sys
    print(tqdm.__version__, sys.version, sys.platform)
4.33.0 3.7.3 | packaged by conda-forge | (default, Jul  1 2019, 14:38:56) 
[Clang 4.0.1 (tags/RELEASE_401/final)] darwin
  • If applicable, I have mentioned the relevant/related issue(s)

(Didn't see any relevant issues; the fix was so easy that I just made a PR instead of an issue.)

@codecov-io
Copy link

codecov-io commented Aug 10, 2019

Codecov Report

Merging #791 into devel will increase coverage by 0.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            devel     #791      +/-   ##
==========================================
+ Coverage   97.65%   98.01%   +0.36%     
==========================================
  Files          10       10              
  Lines         809      805       -4     
  Branches      144      144              
==========================================
- Hits          790      789       -1     
+ Misses         14       12       -2     
+ Partials        5        4       -1

@casperdcl casperdcl self-assigned this Aug 10, 2019
@casperdcl casperdcl added the to-merge ↰ Imminent label Aug 10, 2019
@casperdcl casperdcl changed the base branch from master to devel August 23, 2019 01:47
@casperdcl casperdcl force-pushed the tqdm-notebook-file-None branch from 666ef48 to 0ce91da Compare August 23, 2019 01:50
@casperdcl casperdcl merged commit 0ce91da into tqdm:devel Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants