Fix set_description with tqdm.notebook(disable=True) #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #669 +/- ##
===========================================
+ Coverage 85.56% 99.19% +13.62%
===========================================
Files 15 10 -5
Lines 977 748 -229
Branches 169 132 -37
===========================================
- Hits 836 742 -94
+ Misses 136 2 -134
+ Partials 5 4 -1 |
Codecov Report
@@ Coverage Diff @@
## master #669 +/- ##
==========================================
+ Coverage 99.19% 99.19% +<.01%
==========================================
Files 10 10
Lines 747 748 +1
Branches 132 132
==========================================
+ Hits 741 742 +1
Misses 2 2
Partials 4 4 |
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As self.sp() is called in other places as well (for example if iterable raises exception), I think it's safer to allow calling it even for disabled instances.