Skip to content

Add progress_apply for pd.(Series|DataFrame).(rolling|expanding) #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 15, 2018
Merged

Add progress_apply for pd.(Series|DataFrame).(rolling|expanding) #537

merged 12 commits into from
Apr 15, 2018

Conversation

chengs
Copy link
Contributor

@chengs chengs commented Apr 13, 2018 •
edited
Loading

fixes #530.
Add a progress_bar without total (see #530 for reason).
Maybe should add some documents.

TODO:

  • unittest
  • address errors in checks
  • update documents

@codecov-io
Copy link

codecov-io commented Apr 13, 2018 •
edited
Loading

Codecov Report

Merging #537 into master will decrease coverage by 0.14%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #537      +/-   ##
==========================================
- Coverage   99.41%   99.27%   -0.15%     
==========================================
  Files           8        8              
  Lines         681      686       +5     
  Branches      118      120       +2     
==========================================
+ Hits          677      681       +4     
  Misses          3        3              
- Partials        1        2       +1

@chengs
Copy link
Contributor Author

chengs commented Apr 13, 2018 •
edited
Loading

@casperdcl can you please check if nosttest ./tqdm/tests/tests_perf.py can pass on your machine? Because on mine, even the master branch cannot.

For this PL, all Travis-CI passed except performance, as I only changed code regarding pandas, it should not impact the performance (because pandas is never tested in tests_perf). It is wired...

nosetests --with-timer ./tqdm/tests/tests_perf.py -d -v

@chengs chengs mentioned this pull request Apr 14, 2018
Closed
@casperdcl
fix disable=True edge case
6dad2e8 
Fix #539 where `iterable is not None and not hasattr(iterable, "__len__")`
@casperdcl casperdcl added p3-enhancement 🔥 Much new such feature submodule-notebook 📓 Much web such IDE labels Apr 15, 2018
@casperdcl casperdcl self-requested a review April 15, 2018 00:54
@casperdcl casperdcl added submodule ⊂ Periphery/subclasses and removed submodule-notebook 📓 Much web such IDE labels Apr 15, 2018
@casperdcl
Copy link
Member

casperdcl commented Apr 15, 2018 •
edited
Loading

@chengs regarding perf_tests, that's a separate issue dating back to #60

EDIT now in #540

@casperdcl casperdcl mentioned this pull request Apr 15, 2018
Open
2 tasks
lrq3000 and others added 11 commits April 15, 2018 02:27
@chengs
Copy link
Contributor Author

chengs commented Apr 15, 2018 •
edited
Loading

@casperdcl I see you merge this into devel, so I think it is better first to merge devel into master and bump the version. And then update the document, saying something like “now pandas.Series.rolling.progress_apple is available since version xxx” in a new PL

@casperdcl casperdcl merged commit b2228e1 into tqdm:master Apr 15, 2018
@chengs chengs deleted the pandas-rolling branch April 16, 2018 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl Awaiting requested review from casperdcl casperdcl is a code owner

Assignees

@chengs chengs

Labels
p3-enhancement 🔥 Much new such feature submodule ⊂ Periphery/subclasses
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for tqdm progress bars for "rolling" windows in Pandas
4 participants
@chengs @codecov-io @casperdcl @lrq3000