Add total support to tqdm.pandas()
#535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #535 +/- ##
=======================================
Coverage 99.41% 99.41%
=======================================
Files 8 8
Lines 681 681
Branches 118 118
=======================================
Hits 677 677
Misses 3 3
Partials 1 1 |
Fix #539 where `iterable is not None and not hasattr(iterable, "__len__")`
|
@chengs I don't think the warning is a good idea - if people specify their own |
|
thanks for the unit tests - I left them in. |
total support to tqdm.pandas()
|
@casperdcl, about warning, OK. you make the final decision, so no warning then. |
chengs
commented
Apr 15, 2018
|
Redundant lines? Which ones? Are they still in |
|
@casperdcl no, the devel is good. Ok to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@casperdcl
I think here it should be a warning, because normally total should be automatically computed by tqdm. and only a few cases need manually set total. Like this: