TMonitor warnings #523
Merged
TMonitor warnings #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperdcl
commented
Mar 16, 2018
tqdm/_tqdm.py
Outdated
| from warnings import warn | ||
| warn("tqdm:disabling monitor support" | ||
| " (monitor_interval = 0) due to:\n" + str(e), | ||
| RuntimeWarning) |
There was a problem hiding this comment.
@kalefranz you OK with this?
There was a problem hiding this comment.
I'd make a custom warning, so that it can be specifically disabled without disabling all RuntimeWarnings.
class TqdmDisabledMonitorWarning(RuntimeWarning):
"""Warned when the tqdm update interval monitor is disabled because of system limitations."""And then, in application code, I'd just import the warning, and add
warnings.simplefilter('ignore', TqdmDisabledMonitorWarning)The alternative is forcing applications to disable all RuntimeWarning which I don't think is what you want as a library author. By inheriting from RuntimeWarning instead of just Warning though, you allow users that flexibility if they want it.
Codecov Report
@@ Coverage Diff @@
## master #523 +/- ##
==========================================
+ Coverage 99.24% 99.24% +<.01%
==========================================
Files 7 8 +1
Lines 659 665 +6
Branches 117 117
==========================================
+ Hits 654 660 +6
Misses 3 3
Partials 2 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TqdmMonitorWarningand continue uponTMonitorcreation errors