Flush in refresh() and clean() #327
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for me, without `self.fp.flush()`, refresh always fails in Python 3.5 (but not in 2.7), even with the most mimal test code. added `flush` at the end of `refresh`.
|
@lrq3000 can you remember if/why we deliberately chose to not flush on refresh? |
|
@casperdcl No reason I can remember of, I think it was a confusion because usually we use StatusPrinter to write and it automatically takes care of flushing. clean() also needs flushing, and maybe we should use StatusPrinter instead of directly writing (direct writing is usually done to have more flexibility, but here I can't see nor remember why it would not work OK). |
lrq3000
suggested changes
Dec 29, 2016
|
I am sorry, I got confused about the 2 PR. Now I reverted with another commit, so here is only what belongs here. |
|
No worries, thank you @deeenes for the contributions! 👍 :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for me, without
self.fp.flush(), refresh always fails in Python 3.5 (but not in 2.7), even with the most mimal test code. addedflushat the end ofrefresh.