Skip to content

sys.setcheckinterval (deprecated) changed to sys.setswitchinterval #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

sys.setcheckinterval (deprecated) changed to sys.setswitchinterval #326

wants to merge 2 commits into from

Conversation

deeenes
Copy link
Contributor

@deeenes deeenes commented Dec 23, 2016

sys.setcheckinterval (deprecated) changed to sys.setswitchinterval

@deeenes
Update _tqdm.py
2dd19e8 
`sys.setcheckinterval` (deprecated) changed to `sys.setswitchinterval`
@lrq3000 lrq3000 changed the title Update _tqdm.py sys.setcheckinterval (deprecated) changed to sys.setswitchinterval Dec 27, 2016
@lrq3000
Copy link
Member

lrq3000 commented Dec 29, 2016

Thanks for the PR, note for us: we should enhance this PR to use the deprecated function for old Python versions and the new function for Python 3.

lrq3000
lrq3000 suggested changes Dec 29, 2016
View reviewed changes
Copy link
Member

@lrq3000 lrq3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use both depending on Python version.

lrq3000
lrq3000 approved these changes Dec 29, 2016
View reviewed changes
Copy link
Member

@lrq3000 lrq3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect, thanks a lot! 👍 Greenlight!

@lrq3000 lrq3000 added this to the v5.0.0 milestone Jan 1, 2017
@casperdcl casperdcl closed this in d9c2964 Jan 20, 2017
@casperdcl casperdcl mentioned this pull request Jan 20, 2017
Closed
@maartenbreddels maartenbreddels mentioned this pull request May 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@lrq3000 lrq3000 lrq3000 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Non-breaking
Development

Successfully merging this pull request may close these issues.
2 participants
@deeenes @lrq3000