always flush after moving the cursor to a different line #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
==========================================
+ Coverage 99.52% 99.52% +<.01%
==========================================
Files 7 7
Lines 628 629 +1
Branches 120 120
==========================================
+ Hits 625 626 +1
Misses 1 1
Partials 2 2 |
|
Seems fine, just odd that this implies python3 interleaves output control codes weirdly? |
6ec00f1 to
4b6476a
Compare
|
Can we merge this PR soon? It also fixes the problem for me in #420 |
lrq3000
approved these changes
Sep 22, 2017
|
All good for me. I don't think a unit test is necessary. Also #331 should fix similar issue happening with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue I'm having in #398, by making sure that moveto always flushes the control codes it might write to the terminal in order to move the cursor up one or more lines.
Unfortunately I have no idea of how to write a test case for this. The existing test cases still work, though.