Skip to content

Conversation

casperdcl
Copy link
Member

@casperdcl casperdcl commented May 22, 2017

Fixes the fact that this comment (tqdm/_tqdm.py#L404) was not addressed. (self should not be in cls._instances if position was manually specified). Not sure if this breaks something else - all unit tests pass.

This fixes the example suggested in #384, and possibly #285, #329.

@casperdcl casperdcl requested a review from lrq3000 May 22, 2017 00:47
@casperdcl casperdcl self-assigned this May 22, 2017
@casperdcl casperdcl mentioned this pull request May 22, 2017
@casperdcl casperdcl added p2-bug-warning ⚠ Visual output bad p3-enhancement 🔥 Much new such feature to-review 🔍 Awaiting final confirmation labels May 22, 2017
@nikhilkumarsingh
Copy link

This patch seems to be working for me. Can you please merge it asap?

@casperdcl
Copy link
Member Author

I'll merge it in a week if there are no objections (@lrq3000?)

@casperdcl casperdcl merged commit d3886d6 into master May 28, 2017
@casperdcl casperdcl deleted the nested-fix branch May 29, 2017 00:46
casperdcl added a commit that referenced this pull request Sep 26, 2017
fixes #285 -> #291 -> #329
fixes #422
fixes #439

fixes #323
fixes #324
fixes #334
fixes #407
fixes #418

related to:
- #97
- #143
- #331
- #361
- #384
- #385
- #417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-bug-warning ⚠ Visual output bad p3-enhancement 🔥 Much new such feature to-review 🔍 Awaiting final confirmation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants