Add ncols to specify tqdm_notebook bar width #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 17, 2016
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
=======================================
Coverage 99.41% 99.41%
=======================================
Files 8 8
Lines 681 681
Branches 118 118
=======================================
Hits 677 677
Misses 3 3
Partials 1 1 |
8cade97 to
a65e347
Compare
|
It should be fixed with the latest ipywidgets now :) Didn't try it yet though, if someone can confirm it works it would be great! (and it could be merged in!) |
6ec00f1 to
4b6476a
Compare
|
need some help? @casperdcl |
|
always :) @chengs, feel free to fork, rebase this branch onto master, and open a PR |
|
actually I just added you as a collaborator so you don't need to fork (just push to a new branch here) |
|
It works, but there is a bug on style. I will fix it. |
197960e to
6d63cfd
Compare
|
@casperdcl now it works, and I wrote some test, if they work on your side, I think it is ok to merge. |
fef3765 to
acbc66f
Compare
Fix #539 where `iterable is not None and not hasattr(iterable, "__len__")`
acbc66f to
8018b89
Compare
Signed-off-by: Stephen L. <lrq3000@gmail.com>
8018b89 to
34457bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #276 but does not work yet as layout seems to be broken in current ipywidgets (see jupyter-widgets/ipywidgets#773).
I tried using either
widget.layout.width = 100%andLayout(width='100%'), and in either caseipywidgetsraises an error saying that both are unknown property/can't import Layout class...