Allow bar_format without total or len(iterable) #284
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 90.49% (diff: 100%)@@ master #284 diff @@
==========================================
Files 7 7
Lines 535 484 -51
Methods 0 0
Messages 0 0
Branches 97 87 -10
==========================================
- Hits 491 438 -53
- Misses 43 44 +1
- Partials 1 2 +1
|
|
Thank you @pjvandehaar, this will be merged with #223 which already implements bar_total when there is no total, but your PR has: an extended docstring (should also be added to the readme) + skip if coverall fails. |
|
Alright. Feel free to just copy that docstring and reject this PR. |
8cade97 to
a65e347
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This builds on #283 to allow me to test it locally.)
This PR is a solution to my issue here: #282 .