Skip to content

Create progress bar wrapper to use with dask #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Create progress bar wrapper to use with dask #279

wants to merge 4 commits into from

Conversation

aplavin
Copy link
Contributor

@aplavin aplavin commented Oct 2, 2016 •
edited by lrq3000
Loading

Implements #278 as a submodule, respecting dask API for progress bars.

Dask API:

from dask.diagnostics import ProgressBar

with ProgressBar():
    ... .compute()

This submodule:

from tqdm.dask import ProgressBar

with ProgressBar():
    ... .compute()

@lrq3000 lrq3000 added need-feedback 📢 We need your response (question) submodule ⊂ Periphery/subclasses labels Oct 6, 2016
@lrq3000
Copy link
Member

lrq3000 commented Oct 6, 2016

TODO (not necessarily by you @aplavin!):

  • Should rename ProgressBar() to tqdm_dask() to respect the nomenclatura of other submodules (and the brand name ;) ).
  • Fix unit test failing.
  • Flake8 check.
  • Add to README.

CrazyPython
CrazyPython suggested changes Oct 7, 2016
View reviewed changes
tqdm/__init__.py Outdated


try:
import ._dask as dask
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not valid Python 2.

tqdm/_dask.py Outdated
targs, tkwargs : arguments for the tqdm instance
"""
if not isinstance(tclass, type):
tclass = type(class)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class -> tclass

@codecov-io
Copy link

codecov-io commented Oct 7, 2016 •
edited
Loading

Current coverage is 87.95% (diff: 26.31%)

No coverage report found for master at 5faf18b.

Powered by Codecov. Last update 5faf18b...8cffced

@lrq3000 lrq3000 mentioned this pull request Oct 16, 2016
Closed
@casperdcl casperdcl force-pushed the master branch 4 times, most recently from 8cade97 to a65e347 Compare October 31, 2016 02:34
@casperdcl casperdcl force-pushed the master branch 6 times, most recently from 6ec00f1 to 4b6476a Compare July 22, 2017 14:15
@IvoMerchiers
Copy link

IvoMerchiers commented Aug 26, 2019 •
edited
Loading

@casperdcl Is there any progress on this, or a reason why it was not accepted?

@casperdcl casperdcl mentioned this pull request Aug 26, 2019
Merged
22 tasks
@casperdcl
Copy link
Member

casperdcl commented Aug 26, 2019 •
edited
Loading

@IvoMerchiers thanks for bumping this; probably will be merged within a week after #800

@casperdcl casperdcl added to-review 🔍 Awaiting final confirmation and removed need-feedback 📢 We need your response (question) labels Aug 26, 2019
@casperdcl casperdcl self-assigned this Aug 26, 2019
@casperdcl casperdcl mentioned this pull request Sep 17, 2019
Open
5 tasks
@lpsinger
Copy link
Contributor

I see this has been sitting for several months. Any updates?

@casperdcl casperdcl added this to the Non-breaking milestone Jul 15, 2020
@casperdcl casperdcl added the p3-enhancement 🔥 Much new such feature label Jul 15, 2020
@aplavin aplavin requested a review from casperdcl as a code owner August 2, 2020 14:39
casperdcl added a commit that referenced this pull request Nov 24, 2020
@casperdcl
add dask submodule
0bad223 
- fixes #278
- replaces/closes #279
- based on `tqdm.keras`
@casperdcl casperdcl mentioned this pull request Nov 24, 2020
Merged
3 tasks
casperdcl added a commit that referenced this pull request Feb 22, 2021
@casperdcl
add dask submodule
eb74eb6 
- fixes #278
- replaces/closes #279
- based on `tqdm.keras`
casperdcl added a commit that referenced this pull request Mar 5, 2021
@casperdcl
add dask submodule
f16c888 
- fixes #278
- replaces/closes #279
- based on `tqdm.keras`
@casperdcl casperdcl mentioned this pull request Mar 5, 2021
Merged
This was referenced Mar 8, 2021
Closed
Closed
Closed
Merged
Closed
Closed
Merged
Closed
Closed
Merged
Closed
This was referenced Mar 15, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl Awaiting requested review from casperdcl casperdcl is a code owner

1 more reviewer

@CrazyPython CrazyPython CrazyPython requested changes

Reviewers whose approvals may not affect merge requirements
Assignees

@casperdcl casperdcl

Labels
p3-enhancement 🔥 Much new such feature submodule ⊂ Periphery/subclasses to-review 🔍 Awaiting final confirmation
Projects
None yet
Milestone
Non-breaking
Development

Successfully merging this pull request may close these issues.
7 participants
@aplavin @lrq3000 @codecov-io @IvoMerchiers @casperdcl @lpsinger @CrazyPython