Modularize tqdm.pandas -> tqdm_pandas #271
Conversation
Signed-off-by: Stephen L. <lrq3000@gmail.com>
Current coverage is 91.02% (diff: 6.97%)@@ master #271 diff @@
==========================================
Files 7 7
Lines 479 479
Methods 0 0
Messages 0 0
Branches 86 85 -1
==========================================
+ Hits 433 436 +3
+ Misses 44 41 -3
Partials 2 2
|
caf6d44 to
63755c9
Compare
|
Seems like coveralls is still not disabled. I don't know who owns the coveralls tqdm account, but please disable notifications as per lemurheavy/coveralls-public#93 because I can't find any other way to disable (@casperdcl?). /EDIT: fixed, I disabled coveralls comments. |
Signed-off-by: Stephen L. <lrq3000@gmail.com>
63755c9 to
8346796
Compare
Signed-off-by: Stephen L. <lrq3000@gmail.com>
46488af to
4281e9d
Compare
|
Also this can be interesting to add in the Readme or wiki: http://stackoverflow.com/a/39495229/1121352 |
|
@casperdcl : I managed to get access to coveralls's tqdm account settings and I disabled github comments, so we should not get spam anymore hopefully. If it continues, I will remove coveralls entirely. |
|
@lrq3000 If that doesn't work, use Kill it with fire!if it's located in a former nuclear bunker then... uh... then... Nuke it from orbit. |
8cade97 to
a65e347
Compare
|
See also #245. |
|
We really ought to merge this, the non-uniform API is confusing users: http://stackoverflow.com/questions/40476680/how-to-use-tqdm-with-pandas-in-a-jupyter-notebook |
09c631f to
6ec00f1
Compare
|
is this still in the plan? |
|
yes, it's all part of M8 which we need to focus on |
Modularize tqdm.pandas() back to tqdm_pandas submodule for these reasons:
tqdm, this decreased the coverage in Travis.tqdm_notebook(seetqdm_notebookfor pandas #245).Don't worry about codecov's test not passing the threshold, see #272 for more info on this issue.