Skip to content

cleaner tqdm_notebook exit when not run in a notebook #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2016
Merged

cleaner tqdm_notebook exit when not run in a notebook #267

merged 1 commit into from
Sep 15, 2016

Conversation

to266
Copy link
Contributor

@to266 to266 commented Sep 13, 2016

When not run in a notebook, the sp is not set. This checks if it is set, and exits cleanly.

The idea is to be able to do something like this (with appropriate catching if interested..):

from tqdm import tqdm, tqdm_notebook

def progressbar(*args, **kwargs):
    try:
        return tqdm_notebook(*args, **kwargs)
    except:
        return tqdm(*args, **kwargs)

This is a temporary workaround I found useful while waiting for #234

@coveralls
Copy link

coveralls commented Sep 13, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 90.776% when pulling 8073e69 on to266:notebook_try into 1167fed on tqdm:master.

@CrazyPython
Copy link
Contributor

@lrq3000 reset the build, travis made an api error again

@lrq3000
Copy link
Member

lrq3000 commented Sep 13, 2016

Damn coveralls, it should be disabled by now #263.

@codecov-io
Copy link

Current coverage is 90.56% (diff: 100%)

Merging #267 into master will not change coverage

@@             master       #267   diff @@
==========================================
  Files             7          7          
  Lines           477        477          
  Methods           0          0          
  Messages          0          0          
  Branches         85         85          
==========================================
  Hits            432        432          
  Misses           44         44          
  Partials          1          1

Powered by Codecov. Last update 1167fed...8073e69

@CrazyPython
Copy link
Contributor

@lrq3000 not spamming anymore though...

Damn coveralls, it should be disabled by now #263.

This is what I love about open source and software development in general. Our non-for-profits are lean and snarky startups. And being able to say this too.

@lrq3000 lrq3000 added the p0-bug-critical ☢ Exception rasing label Sep 15, 2016
@lrq3000
Copy link
Member

lrq3000 commented Sep 15, 2016

Thank you @to266 for the clean PR, merging it right now.

@lrq3000 lrq3000 merged commit 166a820 into tqdm:master Sep 15, 2016
@casperdcl casperdcl added p2-bug-warning ⚠ Visual output bad and removed p0-bug-critical ☢ Exception rasing labels Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
p2-bug-warning ⚠ Visual output bad
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@to266 @coveralls @CrazyPython @lrq3000 @codecov-io @casperdcl