Disable coveralls because of duplicate comments on github #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen L. <lrq3000@gmail.com>
Current coverage is 90.56% (diff: 100%)@@ master #263 diff @@
==========================================
Files 7 7
Lines 477 477
Methods 0 0
Messages 0 0
Branches 85 85
==========================================
Hits 432 432
Misses 44 44
Partials 1 1
|
|
@casperdcl You should now be able to reactivate your email notifications without receiving spam comments from coveralls. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coveralls is currently spamming our PR everytime we commit with duplicate comments containing the exact same info. This seems to have started when we merged #232, more exactly when we started caching pip packages like pandas. The error was reported by @CrazyPython to coveralls devs (lemurheavy/coveralls-public#838) but it was closed and their fix doesn't seem to work.
Plus it reduces build time (~5 sec per python version) plus coveralls sometimes fails and makes the build fail.
Anyway, we use codecov since a while as our main coverage report because it is more stringent (branch coverage for codecov instead of statement coverage for coveralls). So we can safely disable it without losing anything.