notebook: support delay
#1142
Merged
notebook: support delay
#1142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## devel #1142 +/- ##
==========================================
- Coverage 89.40% 89.08% -0.32%
==========================================
Files 25 25
Lines 1651 1658 +7
Branches 273 275 +2
==========================================
+ Hits 1476 1477 +1
- Misses 129 132 +3
- Partials 46 49 +3 |
|
I only see one test for tqdm notebook. I'm not sure how to add a test to cover this new logic. |
|
Notebook isn't tested (yet) but I should probably change that soon :) |
|
@peterdhansen I've rebased and added tests, as well as fixed the implementation bugs. Let me know if it works for you now. |
|
Looks good to me. I tried out the new test notebook and looks like it works as intended |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you specify a delay in a jupyter notebook, the bar will always display regardless.
This PR will also delay the
displaycommand until the first update, unless display=True.