Skip to content

replace nose => pytest #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 24, 2020
Merged

replace nose => pytest #1052

merged 10 commits into from
Oct 24, 2020

Conversation

pgajdos
Copy link
Contributor

@pgajdos pgajdos commented Oct 19, 2020

nose will stop working with newer python versions.

@casperdcl casperdcl added eol ☠ Deprecations that are wont-fix candidates p4-enhancement-future 🧨 On the back burner to-fix ⌛ In progress labels Oct 19, 2020
@casperdcl
Copy link
Member

replaces/closes #1045

@pgajdos
Copy link
Contributor Author

pgajdos commented Oct 20, 2020

@casperdcl what do you insist to fix from above failures? Everything? For example, I do not understand 'Method could be a function'. 'Missing function docstring' by inner()? It was not there even before. And 2.6 build?

Thank you for not leaving me alone ;).

@pgajdos
Copy link
Contributor Author

pgajdos commented Oct 20, 2020

I am also not sure with 'TestWithInstancesCheck', perhaps you would find better? And class and functions layout, is it ok?

@casperdcl
Copy link
Member

Thanks @pgajdos ... will review later.

@casperdcl casperdcl self-assigned this Oct 20, 2020
@casperdcl casperdcl added this to the Non-breaking milestone Oct 20, 2020
@casperdcl casperdcl added the to-review 🔍 Awaiting final confirmation label Oct 20, 2020
@casperdcl casperdcl mentioned this pull request Oct 22, 2020
Merged
@codecov-io
Copy link

Codecov Report

Merging #1052 into master will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1052      +/-   ##
==========================================
- Coverage   86.53%   86.40%   -0.14%     
==========================================
  Files          22       22              
  Lines        1456     1456              
  Branches      247      247              
==========================================
- Hits         1260     1258       -2     
- Misses        165      167       +2     
  Partials       31       31

@casperdcl casperdcl added to-merge ↰ Imminent p0-bug-critical ☢ Exception rasing and removed to-fix ⌛ In progress to-review 🔍 Awaiting final confirmation labels Oct 24, 2020
@casperdcl casperdcl changed the base branch from master to devel October 24, 2020 22:57
casperdcl
casperdcl approved these changes Oct 24, 2020
View reviewed changes
Copy link
Member

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • also fixed a py3 CLI bug when using --delim along with --update or --update_to
  • For later: use capsys/capsysbinary instead of all the painful closing(*IO())

@casperdcl casperdcl merged commit d75e1e9 into tqdm:devel Oct 24, 2020
This was referenced Oct 24, 2020
Merged
Open
Merged
@pgajdos pgajdos deleted the denose branch October 26, 2020 11:32
@pgajdos
Copy link
Contributor Author

pgajdos commented Oct 26, 2020

Thanks!

@kevinmarsh kevinmarsh mentioned this pull request Jan 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl casperdcl approved these changes

@chengs chengs Awaiting requested review from chengs chengs is a code owner

Assignees

@casperdcl casperdcl

Labels
eol ☠ Deprecations that are wont-fix candidates p0-bug-critical ☢ Exception rasing p4-enhancement-future 🧨 On the back burner to-merge ↰ Imminent
Projects
None yet
Milestone
Non-breaking
Development

Successfully merging this pull request may close these issues.
3 participants
@pgajdos @casperdcl @codecov-io