Skip to content

Fix test_min_iters() more clearly #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2020
Merged

Fix test_min_iters() more clearly #1003

merged 2 commits into from
Jul 11, 2020

Conversation

heoh
Copy link
Contributor

@heoh heoh commented Jul 11, 2020

I fixed test_min_iters().

Previously, the wrong behavior could also pass.
I fixed the code so that I can test the function clearly.

  • I have marked all applicable categories:
    • exception-raising fix
    • visual output fix
    • documentation modification
    • new feature
  • If applicable, I have mentioned the relevant/related issue(s)

Less important but also useful:

  • I have visited the source website, and in particular
    read the known issues
  • I have searched through the issue tracker for duplicates
  • I have mentioned version numbers, operating system and
    environment, where applicable: 
    import tqdm, sys
print(tqdm.__version__, sys.version, sys.platform)

    4.47.0 3.7.6 | packaged by conda-forge | (default, Jun 1 2020, 18:57:50)
    [GCC 7.5.0] linux

heoh and others added 2 commits July 8, 2020 18:51
@heoh @pica4500
@KOOOOO @namwoong-kim
Fix miniters to work
90078a5 
Default mininterval(0.1) makes miniters to not work.

Co-authored-by: pica4500 <pica4500@gmail.com>
Co-authored-by: KOOOOO <goo1514@naver.com>
Co-authored-by: namwoong-kim <kimnamwoong12@gmail.com>
@heoh @pica4500
@KOOOOO @namwoong-kim
Fix test_min_iters() more clearly
701bf83 
Co-authored-by: pica4500 <pica4500@gmail.com>
Co-authored-by: KOOOOO <goo1514@naver.com>
Co-authored-by: namwoong-kim <kimnamwoong12@gmail.com>
@heoh heoh requested a review from casperdcl as a code owner July 11, 2020 11:23
@casperdcl casperdcl self-assigned this Jul 11, 2020
@casperdcl casperdcl added p3-enhancement 🔥 Much new such feature to-merge ↰ Imminent labels Jul 11, 2020
@casperdcl casperdcl added this to the v5.0.0 milestone Jul 11, 2020
@casperdcl casperdcl changed the base branch from master to devel July 11, 2020 17:16
@casperdcl casperdcl merged commit 400a85e into tqdm:devel Jul 11, 2020
@casperdcl casperdcl mentioned this pull request Jul 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl Awaiting requested review from casperdcl casperdcl is a code owner

Assignees

@casperdcl casperdcl

Labels
p3-enhancement 🔥 Much new such feature to-merge ↰ Imminent
Projects
None yet
Milestone
Non-breaking
Development

Successfully merging this pull request may close these issues.
2 participants
@heoh @casperdcl