Avoid Python 3.13+ RuntimeWarning: coroutine method 'aclose' of 'acount' was never awaited #1595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that these patches fix the issues I have with building tqdm on Fedora 41 with Python 3.13. |
…nt' was never awaited See python/cpython#117536 (comment)
9e75283 to
2fbad6a
Compare
casperdcl
approved these changes
Aug 3, 2024
|
Released in v4.66.5 |
|
Hi @casperdcl thank you for releasing those fixes! |
|
oh I tried but 'tis not on GHA yet |
|
Please try the The last release candidate should arrive on Tuesday 😉 Unfortunately the project is not tracking milestones, but you can use labels if you want to see all open 3.13 issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See python/cpython#117536 (comment)
Built on #1594
This makes the warning go away. However, perhaps
tqdm.close()should try awaitingself.iterable.aclose()if it exists and is awaitable -- that way callers won't need to do that.Let me know if you prefer that and I can propose an alternate PR.