Skip to content

Conversation

theuni
Copy link
Contributor

@theuni theuni commented Jul 14, 2020

Ubuntu ships llvm-config-10. llvm-config-10.0 added as well just in case.

llvm-config-100 makes very little sense so don't bother.

@theuni
Copy link
Contributor Author

theuni commented Jul 15, 2020

Went ahead and added 11 as well, since llvm branched for release today.

@tpoechtrager
Copy link
Owner

You have added them twice. Also add llvm-config100 because that was or is the naming scheme on some BSDs.

@theuni
Copy link
Contributor Author

theuni commented Jul 15, 2020

I added llvm-config-11 and llvm-config-11.0. Note the .0.

Looking in more detail, I see that Ubuntu has shipped without the minor version suffix since llvm-config-7:
https://packages.ubuntu.com/focal/amd64/llvm-8/filelist
https://packages.ubuntu.com/focal/amd64/llvm-7/filelist
https://packages.ubuntu.com/xenial-updates/amd64/llvm-6.0/filelist

I've now pushed a change to add all affected Ubuntu versions as well (7+).

Since llvm 7, Ubuntu ships llvm-config-x rather than llvm-config-x.y
@theuni theuni changed the title Fix lto detection with clang 10 Fix lto detection with recent Ubuntu llvm releases Jul 15, 2020
@tpoechtrager
Copy link
Owner

Note the .0.

Oh, sorry!

Thanks for the patch!

@tpoechtrager tpoechtrager merged commit 70d3058 into tpoechtrager:master Jul 16, 2020
theuni added a commit to theuni/bitcoin that referenced this pull request Jul 16, 2020
tpoechtrager/cctools-port#85 was merged upstream, which
fixes lto detection for external clang with some Linux Distro's including
Ubuntu.
str4d pushed a commit to str4d/zcash that referenced this pull request Jul 30, 2020
tpoechtrager/cctools-port#85 was merged upstream, which
fixes lto detection for external clang with some Linux Distro's including
Ubuntu.
Warchant pushed a commit to Warchant/bitcoin that referenced this pull request Aug 6, 2020
tpoechtrager/cctools-port#85 was merged upstream, which
fixes lto detection for external clang with some Linux Distro's including
Ubuntu.
janus pushed a commit to janus/bitgesell that referenced this pull request Nov 22, 2020
tpoechtrager/cctools-port#85 was merged upstream, which
fixes lto detection for external clang with some Linux Distro's including
Ubuntu.
Fuzzbawls pushed a commit to Fuzzbawls/PIVX that referenced this pull request Mar 26, 2021
tpoechtrager/cctools-port#85 was merged upstream, which
fixes lto detection for external clang with some Linux Distro's including
Ubuntu.
Fuzzbawls pushed a commit to Fuzzbawls/PIVX that referenced this pull request Mar 26, 2021
tpoechtrager/cctools-port#85 was merged upstream, which
fixes lto detection for external clang with some Linux Distro's including
Ubuntu.
Fuzzbawls pushed a commit to Fuzzbawls/PIVX that referenced this pull request Apr 5, 2021
tpoechtrager/cctools-port#85 was merged upstream, which
fixes lto detection for external clang with some Linux Distro's including
Ubuntu.
lyricidal added a commit to PRCYCoin/PRCYCoin that referenced this pull request Oct 30, 2021
tpoechtrager/cctools-port#85 was merged upstream, which
fixes lto detection for external clang with some Linux Distro's including Ubuntu.
lyricidal added a commit to PRCYCoin/PRCYCoin that referenced this pull request Oct 31, 2021
tpoechtrager/cctools-port#85 was merged upstream, which
fixes lto detection for external clang with some Linux Distro's including Ubuntu.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants