Skip to content

Final performance restructure on Model constructor. A further 9~11% s… #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2018
Merged

Final performance restructure on Model constructor. A further 9~11% s… #52

merged 1 commit into from
Oct 1, 2018

Conversation

grigi
Copy link
Member

@grigi grigi commented Sep 28, 2018

A further 9~11% speedup.

I also tried to restructure the constructor to be more logically grouped and added comments.

@coveralls
Copy link

coveralls commented Sep 28, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 204

  • 20 of 21 (95.24%) changed or added relevant lines in 1 file are covered.
  • 318 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.8%) to 91.547%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tortoise/models.py 20 21 95.24%
Files with Coverage Reduction New Missed Lines %
tortoise/backends/base/executor.py 1 95.56%
tortoise/backends/mysql/init.py 2 100.0%
tortoise/backends/asyncpg/init.py 2 100.0%
tortoise/models.py 3 94.04%
tortoise/backends/asyncpg/schema_generator.py 8 100.0%
tortoise/backends/base/client.py 8 91.07%
tortoise/backends/mysql/schema_generator.py 13 100.0%
tortoise/backends/asyncpg/executor.py 13 100.0%
tortoise/backends/mysql/executor.py 29 100.0%
tortoise/backends/asyncpg/client.py 117 80.37%
Totals Coverage Status
Change from base Build 202: 0.8%
Covered Lines: 730
Relevant Lines: 781
💛 - Coveralls

@grigi grigi requested a review from abondar September 28, 2018 20:49
@abondar abondar merged commit 621911a into master Oct 1, 2018
@abondar abondar deleted the feature/papercuts branch November 23, 2018 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abondar abondar Awaiting requested review from abondar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grigi @coveralls @abondar