Performance tuning #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also cleared up a few lint warnings.
Pull Request Test Coverage Report for Build 201
💛 - Coveralls |
abondar
reviewed
Sep 27, 2018
tortoise/backends/asyncpg/client.py
Outdated
| @@ -172,7 +173,7 @@ def acquire_connection(self): | |||
| async def commit(self): | |||
| try: | |||
| await self.transaction.commit() | |||
| except asyncpg.exceptions._base.InterfaceError as exc: | |||
| except (AttributeError, asyncpg.exceptions._base.InterfaceError) as exc: | |||
There was a problem hiding this comment.
What is the case here? You managed to catch it without transaction?
There was a problem hiding this comment.
That was because the linter (correctly) complained that it was possible for self.transaction to not exist. Which is now forcefully set to None instead. AttributeError is if it is a None value.
I should probably make it clearer? Or is it perferred for it to raise a NPE?
Now that I think of it, a NPE would point out that something happened that should never be able to happen...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tortoise.models.__init__restructure give 25-30% speedup in select benchmark.Usage of
pypika>=0.15.6gives 53% speedup in insert benchmark.I also cleared up a few lint warnings.
As per findings in https://github.com/tortoise/orm-benchmarks
(The benchmark is currently only using SQLite, but both these changes should be generic)