Refactor packages: review UDP events #1328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will splot UDP stats events into: - UDP core events - UDP server event This is step 1 in the refactor: - Step 1. Create UDP server events. - Step 2. Remove UDP server events from core events.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1328 +/- ##
===========================================
+ Coverage 81.09% 81.47% +0.37%
===========================================
Files 222 230 +8
Lines 15971 16372 +401
Branches 15971 16372 +401
===========================================
+ Hits 12952 13339 +387
- Misses 2784 2810 +26
+ Partials 235 223 -12 ☔ View full report in Codecov by Sentry. |
1d046b9 to
4a31c6e
Compare
4a31c6e to
4c61f7d
Compare
…re package Some events were moved from the `udp-tracker-core` package to the `udp-tracker-server` package. This commits remmoves the unused events from the `udp-tracker-core`.
4c61f7d to
b8d2f76
Compare
|
ACK b8d2f76 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the UDP stats events into two different types of events (one for each layer):
Subtasks