Skip to content

Refactor: extract WhitelistManager #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 15, 2025
Merged

Refactor: extract WhitelistManager #1183

merged 11 commits into from
Jan 15, 2025

Conversation

josecelano
Copy link
Member

Refactor: extract WhitelistManager

@josecelano josecelano self-assigned this Jan 15, 2025
@josecelano josecelano added Code Cleanup / Refactoring Tidying and Making Neat - Developer - Torrust Improvement Experience labels Jan 15, 2025
@josecelano josecelano linked an issue Jan 15, 2025 that may be closed by this pull request
Overhaul core Tracker: extract whitelist #1182
Closed
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.13084% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.60%. Comparing base (b403382) to head (57455ca).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
src/core/whitelist/mod.rs 91.42% 3 Missing ⚠️
src/core/whitelist/persisted.rs 91.66% 0 Missing and 2 partials ⚠️
src/core/services/mod.rs 95.45% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1183      +/-   ##
===========================================
+ Coverage    76.22%   76.60%   +0.38%     
===========================================
  Files          178      181       +3     
  Lines        11898    12002     +104     
  Branches     11898    12002     +104     
===========================================
+ Hits          9069     9194     +125     
+ Misses        2658     2646      -12     
+ Partials       171      162       -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano josecelano force-pushed the 1182-overhaul-core-tracker-extract-whitelist branch from 1aa312b to cc2bc7b Compare January 15, 2025 11:24
@josecelano
refactor: [torrust#1182] inject database and whitelist in tracker as dep
2f1abeb 
Inject the database (persistence) and whitelist manager into the Tracker
via the contructor to be able to use the whitelist manager directly in
Axum handlers.
@josecelano
refactor: [torrust#1182] use WhitelistManager in API handlers
4253d0f 
directly, instead of using it via the Tracker.
@josecelano
refactor: [torrust#1182] inject database and whitelist manager in tra…
658d2be 
…cker factory

Refactor in progress. The final goal is to inject the whitelist manager
directly wherever is needed (for example, test evns) to avoid injecting
the whole tracker. Adn to finally remove the whitelist manager from the
Tracker (A higer level refator in progress: remove responsabilities
fromcore Tracker).
@josecelano josecelano marked this pull request as ready for review January 15, 2025 17:51
@josecelano josecelano requested a review from da2ce7 January 15, 2025 17:51
@josecelano
Copy link
Member Author

ACK 57455ca

@josecelano josecelano merged commit b7e009d into torrust:develop Jan 15, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da2ce7 da2ce7 Awaiting requested review from da2ce7

Assignees

@josecelano josecelano

Labels
- Developer - Torrust Improvement Experience Code Cleanup / Refactoring Tidying and Making Neat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overhaul core Tracker: extract whitelist
1 participant
@josecelano