docs: Add notice about WindowsSelectorEventLoop on py38 #2686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazka
added a commit
to lazka/pyperformance
that referenced
this pull request
Jul 23, 2019
tornado requires the WindowsSelectorEventLoop on Windows but Python 3.8 changed the default event loop which breaks the tornado benchmarks. This makes WindowsSelectorEventLoop the default again like suggested in: tornadoweb/tornado#2686 Fixes python#61
lazka
added a commit
to lazka/pyperformance
that referenced
this pull request
Jul 29, 2019
Python 3.8 changed the default event loop to ProactorEventLoop which doesn't implement everything required by tornado and breaks the benchmark. This makes WindowsSelectorEventLoop the default again like suggested in: tornadoweb/tornado#2686 Limit to 3.8 only in the hopes that the new event loop supports the required methods with 3.9. Fixes python#61
vstinner
pushed a commit
to python/pyperformance
that referenced
this pull request
Jul 30, 2019
Python 3.8 changed the default event loop to ProactorEventLoop which doesn't implement everything required by tornado and breaks the benchmark. This makes WindowsSelectorEventLoop the default again like suggested in: tornadoweb/tornado#2686 Limit to 3.8 only in the hopes that the new event loop supports the required methods with 3.9. Fixes #61
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2608