Skip to content

Conversation

SteveLauC
Copy link
Member

What does this PR do

Based on this comment, fixes #928.

Standards checklist

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

@SteveLauC
Copy link
Member Author

Here is a build of Topgrade with this patch included, cc @rabin-io @lucaspar, could you guys please give it a test?

@rabin-io
Copy link

rabin-io commented Oct 8, 2024

@SteveLauC looks good from my end, works with my current config (as above).

Copy link
Contributor

@lucaspar lucaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SteveLauC
Copy link
Member Author

Thanks for testing it!

@SteveLauC SteveLauC merged commit 4932700 into topgrade-rs:main Oct 8, 2024
12 checks passed
@SteveLauC SteveLauC deleted the fix/tmux branch October 8, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unknown command: attach-client
3 participants