Containers step: new runtime option to configuration #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveLauC
approved these changes
Aug 31, 2024
There was a problem hiding this comment.
LGTM, but this is a breaking change when a user has both Podman and Docker installed, before this PR, Podman will be used, now the default option becomes Docker. We need to document this in BREAKINGCHANGES_dev.md.
|
Right - this is actually my situation and what motivated the change. Most of my containers are in fact under docker and they couldn't be updated with topgrade before. I'll document it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
containers.runtimeoption to the TOML configuration, letting the user select what used to be an implicit choice.docker, as it's the most commonly used runtime.Open to suggestions.
Standards checklist
CONTRIBUTING.md