Fix builds and runs on DragonFly BSD #569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Include a missing use for a referenced type * Add a missing step to do as is done on the FreeBSD code, which should be the same on this step as for DragonFly BSD * Go against what clippy says for the sake of not actually crashing if an audit of packages fails. Absent this change, status_checked() will actually cause the run to crash at that step rather than say that that specific step failed and continue, which is not the expected behavior.
|
Thanks for doing this!
If we get a clippy warning, and it is ignorable, we can use |
Are you asking me to write an allow right above the line in my commit? |
Yep, that would silence it :) |
SteveLauC
approved these changes
Oct 8, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include a missing use for a referenced type
Add a missing step to do as is done on the FreeBSD code, which should be the same on this step as for DragonFly BSD
Go against what clippy says for the sake of not actually crashing if an audit of packages fails. Absent this change, status_checked() will actually cause the run to crash at that step rather than say that that specific step failed and continue, which is not the expected behavior.
Standards checklist:
CONTRIBUTING.mdcargo build)cargo fmt)cargo clippy)cargo test)For new steps
--dry-runoption works with this step--yesoption works with this step if it is supported bythe underlying command
If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.