Skip to content

feat: better error message on wrong os-release file #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 24, 2023
Merged

feat: better error message on wrong os-release file #511

merged 5 commits into from
Jul 24, 2023

Conversation

6543
Copy link
Contributor

@6543 6543 commented Jul 22, 2023 •
edited
Loading

closes #499

  • bump rust-ini get rid of the panic
  • detect if something is wrong with os-release

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)

@6543 6543 changed the title Better err msg os release feat: better error message on wrong os-release file Jul 22, 2023
@6543 6543 mentioned this pull request Jul 22, 2023
Closed
@6543
Copy link
Contributor Author

6543 commented Jul 22, 2023

2023-07-22_22-56

SteveLauC
SteveLauC requested changes Jul 23, 2023
View reviewed changes
@SteveLauC
Copy link
Member

Except for that little grammar mistake, this PR LGTM, thanks! :)

6543
6543 commented Jul 23, 2023
View reviewed changes
@6543 6543 requested a review from SteveLauC July 23, 2023 15:11
@6543
Copy link
Contributor Author

6543 commented Jul 23, 2023 •
edited
Loading

Done :)

As pulls are squash merged i did just append the commit.
If i have to squash them tell me

@SteveLauC 🚀

@SteveLauC SteveLauC merged commit 1307d2d into topgrade-rs:master Jul 24, 2023
@6543 6543 deleted the better_err_msg_os-release branch July 24, 2023 03:45
@chenrui333 chenrui333 mentioned this pull request Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveLauC SteveLauC SteveLauC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better error message when os-release file parsing goes wrong
2 participants
@6543 @SteveLauC