Skip to content

bootc exists on system but disabled via config will ignore rpm-ostree #997

@befanyt

Description

@befanyt

Erroneous Behavior

Tried to update my system. With rpm-ostree=true and bootc=false (default). My system has bootc on it, so it found it but it is disabled via config and tries to update via dnf now.

Expected Behavior

topgrade should have used rpm-ostree to update the system

Steps to reproduce

Update the system with topgrade, where bootc is available but disabled on the system.

Possible Cause (Optional)

} else if let Some(ostree) = which("rpm-ostree") {

I think that needs to be just an if statement, and not if else. Because bootc is found, then checks config which is disabled. Because bootc exists it will never go into the rpm-ostree flow when it finds out that it is disabled via config.

Problem persists without calling from topgrade

  • Yes
  • No

Did you run topgrade through Remote Execution

  • Yes
  • No

If yes, does the issue still occur when you run topgrade directlly in your
remote host

  • Yes
  • No

Configuration file (Optional)

[misc]
no_self_update = true
only = ["system", "flatpak", "distrobox", "firmware"]
disable = ["self_update", "toolbx", "containers", "helm"]
ignore_failures = ["distrobox", "flatpak", "brew_cask", "brew_formula", "nix", "node", "pip3", "home_manager", "firmware"]
assume_yes = true
no_retry = false

[linux]
rpm_ostree = true

Additional Details

  • Operation System/Version

Universal Blue Bluefin

  • Installation

Via pip I think, its included in bluefin

  • Topgrade version (topgrade -V)
    topgrade 16.0.2

Verbose Output (topgrade -v)

── 14:44:42 - System update ────────────────────────────────────────────────────
DEBUG Detected "/usr/bin/bootc" as "bootc"
DEBUG Detected "/usr/bin/dnf" as "dnf"
DEBUG Executing command `/usr/bin/sudo /usr/bin/dnf upgrade`

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions