Skip to content

test/e2e: add a script to run minikube e2e tests on multipass #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025

Conversation

ushitora-anqou
Copy link
Contributor

@ushitora-anqou ushitora-anqou commented Jul 17, 2025

The current end-to-end test documentation shows how to run the tests directly on the host machine. Because they use Minikube's none driver, this can unexpectedly modify the host's environment.

This commit adds instructions for running the tests in a Multipass VM instead, so developers can execute them without cluttering or altering their local environments.

@toshipp toshipp moved this from To do to In progress in Development Jul 18, 2025
@ushitora-anqou ushitora-anqou force-pushed the test/e2e/readme/add-multipass-script branch 2 times, most recently from e3daf2c to 97bae8e Compare July 22, 2025 00:36
@ushitora-anqou ushitora-anqou marked this pull request as ready for review July 22, 2025 09:10
@ushitora-anqou ushitora-anqou requested a review from a team as a code owner July 22, 2025 09:10
@ushitora-anqou ushitora-anqou requested review from pluser and peng225 July 22, 2025 09:10
@pluser
Copy link
Contributor

pluser commented Jul 22, 2025

Because it includes version number, it may be a good idea to update the version number during maintenance.

Edit the following files.
- `docs/advanced-setup.md`
- `README.md`
- `versions.mk`
- `.github/workflows/e2e-k8s-incluster-lvmd.yaml`
- `.github/workflows/e2e-k8s-workflow.yaml`

peng225
peng225 previously approved these changes Jul 22, 2025
The current end-to-end test documentation shows how to run the tests
directly on the host machine. Because they use Minikube's none driver,
this can unexpectedly modify the host's environment.

This commit adds instructions for running the tests in a Multipass VM
instead, so developers can execute them without cluttering or altering
their local environments.

Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
@ushitora-anqou ushitora-anqou requested a review from peng225 July 23, 2025 00:16
@peng225 peng225 merged commit 396d590 into main Jul 23, 2025
8 checks passed
@peng225 peng225 deleted the test/e2e/readme/add-multipass-script branch July 23, 2025 02:11
@github-project-automation github-project-automation bot moved this from In progress to Done in Development Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants