report capacity after volume expansion to Block-mode PVC #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If volumeMode is set to Block, executing NodeExpandVolume to expand filesystem is unnecessary. Signed-off-by: Kyori Sakao <sakaok@cybozu.co.jp>
a83fadd to
3686165
Compare
molpako
commented
Jun 23, 2025
| @@ -638,13 +638,14 @@ func (s controllerServerNoLocked) ControllerExpandVolume(ctx context.Context, re | |||
| currentSize = &lv.Spec.Size | |||
| } | |||
|
|
|||
| _, nodeExpansionRequired := req.VolumeCapability.GetAccessType().(*csi.VolumeCapability_Mount) | |||
There was a problem hiding this comment.
I chose a variable name that emphasizes its intended use rather than a state-like name such as isMount. Please let me know if you have any feedback.
Signed-off-by: Kyori Sakao <sakaok@cybozu.co.jp>
3686165 to
6deddfa
Compare
ushitora-anqou
approved these changes
Jun 23, 2025
llamerada-jp
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When node-expansion disabled for block-mode PVC, the external-resizer receives the expanded volume capacity and sets it as the PVC status.
This change modifies TopoLVM driver's ControllerExpandVolume to report the expanded volume capacity in such cases.