Update colors in design.md file #1058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @remidinishanth, Thank you for submitting your PR. I appreciate your efforts. I have a suggestion regarding the handling of user-uploaded files. It can be challenging to manage these files since only the uploader knows their origin and purpose. To ensure consistency and ease of management, I recommend storing the necessary image files directly in the repository. This approach will make it easier for everyone to access and maintain them. Additionally, I believe the alt attribute is sufficient for accessibility purposes. Here's a proposed change to your patch: - -  TopoLVM components
- -  Kubernetes components
- -  Kubernetes CSI Sidecar containers
+ -  TopoLVM components
+ -  Kubernetes components
+ -  Kubernetes CSI Sidecar containers |
Signed-off-by: Nishanth Reddy <remidinishanth@gmail.com>
|
Thanks for the comment @daichimukai , I've updated, Please take another look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the color links are broken in
design.mdfileThe old link is giving the error
Cannot proxy the given URLFixing the same, also keeping the hex code as reference.
Before
After