Cleanup deprecated fields usage #1056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cupnes
reviewed
Jun 12, 2025
|
I will approve after cupnes's conversation is reflected. |
5a54991 to
eafa0a4
Compare
We have been using the GB unit for device sizes, but it has been deprecated for a long time, so let's clean them up. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
eafa0a4 to
576ab65
Compare
cupnes
approved these changes
Jun 27, 2025
|
I changed it to draft to fix conflicts. It is reviewable now. |
|
@pluser Could you review this? |
pluser
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been using the GB unit for device sizes, but it has been deprecated for a long time, so let's clean them up.
Note: this breaks compatibility with very old lvmd.