lvmd: support lvm-command-prefix option in lvmd.conf #1045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daac12f to
ed7d6e9
Compare
87b25c3 to
e1efbb3
Compare
446f42b to
a728203
Compare
a7b8f04 to
52e432b
Compare
8af1676 to
ed1cc96
Compare
toshipp
requested changes
Jul 10, 2025
baefd35 to
7201212
Compare
7201212 to
b04458a
Compare
Implemented in the following commits:
|
toshipp
approved these changes
Jul 11, 2025
jakobmoellerdev
approved these changes
Jul 11, 2025
llamerada-jp
approved these changes
Jul 14, 2025
In DaemonSet mode, LVMd currently executes every LVM command through /usr/bin/nsenter with hard-coded arguments. This prevents users from: - Changing the path to nsenter or its options - Wrapping the command in a logging program or other tool - Running LVM commands without nsenter (though this is risky) This commint introduces the lvm-command-prefix option in lvmd.conf to provide that flexibility. The value is a list of strings that will be prepended to every command invocation. For example, if it is set to X, LV creation will be invoked as `X /sbin/lvm lvcreate ...`. The default value of this option is equivalent to `/usr/bin/nsenter -m -u -i -n -p -t 1`, so the current behaviour will not break by default. Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
This commit adds the `lvmd.additionalLVMDYamlContent` key to values.yaml, enabling users to append extra settings to the generated lvmd.yaml file. Please note that this option is different from `lvmd.additionalConfigs`, which creates a separate lvmd.yaml ConfigMap instead of modifying the existing one. Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
We have two options to adapt LVM command invocation i.e., --lvm-path option and lvm-command-prefix setting. The lvm-command-prefix setting is more general than --lvm-path, so the --lvm-path option is not necessary anymore. This commit deprecates the option. Users should use lvm-command-prefix instead. Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
b04458a to
6f8f7f8
Compare
|
I'll merge this PR because there's no code change after the reviewers approved it: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1042.
In DaemonSet mode, LVMd currently executes every LVM command through
/usr/bin/nsenter with hard-coded arguments. This prevents users from:
This commint introduces the lvm-command-prefix option in lvmd.conf to
provide that flexibility. The value is a list of strings that will be
prepended to every command invocation. For example, if it is set to X,
LV creation will be invoked as
X /sbin/lvm lvcreate ....The default value of this option is equivalent to
/usr/bin/nsenter -m -u -i -n -p -t 1, so the current behaviour will not break bydefault.