Skip to content

Remove checking some k8s.io dependencies #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Remove checking some k8s.io dependencies #1014

merged 1 commit into from
Feb 13, 2025

Conversation

toshipp
Copy link
Contributor

@toshipp toshipp commented Feb 12, 2025

Since controller-runtime depends on them, there is no need to check themselves.

Since controller-runtime depends on them, there is no need to check
themselves.

Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
@toshipp toshipp requested a review from a team as a code owner February 12, 2025 07:15
Copy link
Contributor

@pluser pluser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The possibility of these dependencies being removed in the future is very low. So I think it's good. 👍

@toshipp toshipp merged commit 1aa8f8d into main Feb 13, 2025
9 checks passed
@toshipp toshipp deleted the k8s-issue branch February 13, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants