Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: topolvm/topolvm
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.36.3
Choose a base ref
...
head repository: topolvm/topolvm
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.36.4
Choose a head ref
  • 8 commits
  • 8 files changed
  • 7 contributors

Commits on Apr 3, 2025

  1. Bump chart version to 15.5.3

    Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    github-actions[bot] committed Apr 3, 2025
    Configuration menu
    Copy the full SHA
    2be8ebb View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1030 from topolvm/bump-chart-15.5.3

    Bump chart version to 15.5.3
    ushitora-anqou authored Apr 3, 2025
    Configuration menu
    Copy the full SHA
    67c0411 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2025

  1. Remove duplicated entries from container-structure-test.yaml

    Signed-off-by: Daichi Mukai <daichi-mukai@cybozu.co.jp>
    daichimukai committed Apr 15, 2025
    Configuration menu
    Copy the full SHA
    1eb6f7e View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2025

  1. chore(deps): bump golang.org/x/net from 0.36.0 to 0.38.0

    Bumps [golang.org/x/net](https://github.com/golang/net) from 0.36.0 to 0.38.0.
    - [Commits](golang/net@v0.36.0...v0.38.0)
    
    ---
    updated-dependencies:
    - dependency-name: golang.org/x/net
      dependency-version: 0.38.0
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Apr 16, 2025
    Configuration menu
    Copy the full SHA
    47bf927 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2025

  1. Merge pull request #1031 from topolvm/remove-duplicated-entries-from-…

    …container-structure-test
    
    Remove duplicated entries from container-structure-test.yaml
    satoru-takeuchi authored Apr 17, 2025
    Configuration menu
    Copy the full SHA
    7ee7302 View commit details
    Browse the repository at this point in the history
  2. Ignore non-filesystem signatures when re-mounting filesystem PVC

    topolvm-node sometimes fails to mount a filesystem PVC that was
    previously formatted and mounted to a Pod. This issue appears to stem
    from topolvm-node's filesystem detection method, which uses blkid and
    may report non-filesystem signatures, such as RAID member signatures
    located in the last sector of the block device. Consequently,
    topolvm-node interprets this as a filesystem inconsistency error,
    resulting in a failure to mount. These should be considered false
    positives, as the devices being mounted are intended solely for the
    filesystem specified in the PVC spec.
    
    During NodePublishVolume requests, topolvm-node attempts to detect the
    filesystem twice. The first detection is performed with its own
    implementation, and the second is done by FormatAndMount() provided by
    Kubernetes' mount-utils. Currently, both implementations perform
    essentially the same function. We can easily modify the former
    implementation, but the latter is more challenging to adjust.
    
    To address this issue, this commit modifies topolvm's filesystem
    detection method to ignore any usage other than filesystems in its own
    implementation. Additionally, we avoid using FormatAndMount() when an
    existing filesystem is detected, and instead use Mount(), which does not
    check the existing disk format. While this fix does not address false
    positives for newly created PVCs, it prioritizes resolving the
    re-mounting issue. Newly created PVCs are not yet in use, allowing us
    time to address any issues manually.
    
    Signed-off-by: Daichi Mukai <daichi-mukai@cybozu.co.jp>
    daichimukai committed Apr 17, 2025
    Configuration menu
    Copy the full SHA
    98742e0 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2025

  1. Merge pull request #1033 from topolvm/ignore-non-filesystem-signatures

    Ignore non-filesystem signatures when re-mounting filesystem PVC
    peng225 authored Apr 18, 2025
    Configuration menu
    Copy the full SHA
    0facba9 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1032 from topolvm/dependabot/go_modules/golang.or…

    …g/x/net-0.38.0
    
    chore(deps): bump golang.org/x/net from 0.36.0 to 0.38.0
    toshipp authored Apr 18, 2025
    Configuration menu
    Copy the full SHA
    a2c3a98 View commit details
    Browse the repository at this point in the history
Loading