fix: Doesn't drop entire PG database, just cleans public schema - Cog 1947 #760

Vasilije1990 · 2025-04-19T18:42:46Z

Description

DCO Affirmation

I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.

pull-checklist · 2025-04-19T18:42:51Z

Please make sure all the checkboxes are checked:

I have tested these changes locally.
I have reviewed the code changes.
I have added end-to-end and unit tests (if applicable).
I have updated the documentation and README.md file (if necessary).
I have removed unnecessary code and debug statements.
PR title is clear and follows the convention.
I have tagged reviewers or team members for feedback.

coderabbitai · 2025-04-19T18:42:52Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The update modifies the logic in the delete_database method of the SqlAlchemyAdapter class. Previously, the method iterated through all schemas in non-SQLite databases and dropped every table in each schema. The revised approach now restricts table deletion to only the "public" schema, reflecting and dropping all tables within it. Additionally, a minor typographical correction was made in a comment within the delete_table method. There are no changes to method signatures or exported entities.

Changes

File(s)	Change Summary
cognee/infrastructure/databases/relational/sqlalchemy/SqlAlchemyAdapter.py	Simplified `delete_database` to only drop tables in "public" schema; fixed comment apostrophe.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SqlAlchemyAdapter
    participant Database

    User->>SqlAlchemyAdapter: call delete_database()
    SqlAlchemyAdapter->>Database: reflect tables in "public" schema
    SqlAlchemyAdapter->>Database: drop all tables in "public" schema
    SqlAlchemyAdapter-->>User: operation complete

Possibly related PRs

topoteretes/cognee#163: Refactored the same delete_database method to handle multiple schemas and added schema utilities, directly related to the logic now being simplified.

Poem

In the land of schemas, wide and grand,
Now we sweep just one, as planned.
"Public" tables fall with grace,
No more searching every place.
A tidy hop, a simpler run—
This rabbit’s work is neatly done!
🐇✨

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

dexters1 · 2025-04-25T10:12:49Z

cognee/infrastructure/databases/relational/sqlalchemy/SqlAlchemyAdapter.py

-                            await connection.execute(drop_table_query)
-                        metadata.clear()
+                    # Drop all tables from the public schema
+                    schema_name = "public"


The 'public_staging' schema also should be deleted, it's created by dlt

Added deletion of 'public_staging' schema as well

Vasilije1990 added 5 commits April 18, 2025 16:31

merge

8afbecf

Merge branch 'dev' of github.com:topoteretes/cognee into dev

7bdb2ab

Merge branch 'dev' of github.com:topoteretes/cognee into dev

b35e047

Merge branch 'dev' of github.com:topoteretes/cognee into dev

2a485f9

removed delete of entire db

d22e37e

Vasilije1990 and others added 2 commits April 19, 2025 22:13

Merge branch 'main' into COG-1947

9a965b0

Merge branch 'main' into COG-1947

9b1e7f0

borisarzentar marked this pull request as ready for review April 25, 2025 09:31

dexters1 reviewed Apr 25, 2025

View reviewed changes

dexters1 changed the base branch from main to dev April 25, 2025 10:15

dexters1 and others added 3 commits April 25, 2025 12:17

Merge branch 'dev' into COG-1947

7f8297e

feat: Add deletion of public_staging schema

6fd7a67

refactor: Update exception name

295c30e

dexters1 approved these changes Apr 25, 2025

View reviewed changes

Vasilije1990 merged commit 5aca3f0 into dev Apr 25, 2025
48 of 49 checks passed

Vasilije1990 deleted the COG-1947 branch April 25, 2025 22:00

coderabbitai bot mentioned this pull request May 24, 2025

fix: Add getting started tutorial to git #870

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Doesn't drop entire PG database, just cleans public schema - Cog 1947 #760

fix: Doesn't drop entire PG database, just cleans public schema - Cog 1947 #760

Uh oh!

Vasilije1990 commented Apr 19, 2025

Uh oh!

pull-checklist bot commented Apr 19, 2025

Uh oh!

coderabbitai bot commented Apr 19, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

dexters1 Apr 25, 2025 •

edited

Loading

Uh oh!

dexters1 Apr 25, 2025

Uh oh!

Uh oh!

Uh oh!

fix: Doesn't drop entire PG database, just cleans public schema - Cog 1947 #760

fix: Doesn't drop entire PG database, just cleans public schema - Cog 1947 #760

Uh oh!

Conversation

Vasilije1990 commented Apr 19, 2025

Description

DCO Affirmation

Uh oh!

pull-checklist bot commented Apr 19, 2025

Please make sure all the checkboxes are checked:

Uh oh!

coderabbitai bot commented Apr 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

dexters1 Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dexters1 Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot commented Apr 19, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

dexters1 Apr 25, 2025 •

edited

Loading