Skip to content

feat(defaultsDeep): add defaultsDeep to compat/object #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 25, 2025
Merged

feat(defaultsDeep): add defaultsDeep to compat/object #1183

merged 7 commits into from
May 25, 2025

Conversation

hwibaski
Copy link
Contributor

close #1030

1. Test

스크린샷 2025-05-12 오전 10 21 50

2. Coverage

image

3. Benchmark

image

@vercel Vercel
Copy link

vercel bot commented May 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2025 9:10pm

@hwibaski hwibaski force-pushed the feat/defaultsDeep branch from 4ecd860 to 43ddbb7 Compare May 12, 2025 01:42
@hwibaski hwibaski changed the title feat(defaultsDeep): add defaultsDeep to compat/object feat[defaultsDeep]: add defaultsDeep to compat/object May 12, 2025
@hwibaski
Copy link
Contributor Author

Hi team,😀
I tried to check why the deployment step is failing, but it seems I don't have the necessary permission to access the deployment logs or related details.
Could you please take a look when you have a chance and let me know if you find any issues?
I’d really appreciate your help.

Thank you in advance!

@hwibaski
Copy link
Contributor Author

hwibaski commented May 12, 2025 •
edited
Loading

Hi team,😀 I tried to check why the deployment step is failing, but it seems I don't have the necessary permission to access the deployment logs or related details. Could you please take a look when you have a chance and let me know if you find any issues? I’d really appreciate your help.

Thank you in advance!

I found an issue in the Japanese documentation where it was linking to a non-existent markdown file, and I’ve fixed it.

@hwibaski hwibaski mentioned this pull request May 12, 2025
Closed
@raon0211 raon0211 changed the title feat[defaultsDeep]: add defaultsDeep to compat/object feat(defaultsDeep): add defaultsDeep to compat/object May 17, 2025
@hwibaski
Copy link
Contributor Author

Thanks a lot for adding the test cases! They all pass locally for me, but seem to be failing on CI. I'm not sure what the next step is — should I look into this further, or is there something you'd recommend I check?
Appreciate your guidance!

@raon0211
Copy link
Collaborator

Hey, thanks for your contribution! You can check which test failed in the CI in the "tests" tab as shown in the image. It seems that there were some temporary problems in the CI environment, so I just ran the test again.

image

raon0211
raon0211 previously approved these changes May 25, 2025
View reviewed changes
Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your work!

@raon0211 raon0211 merged commit 02ac7b5 into toss:main May 25, 2025
6 of 7 checks passed
@injae-kim
Copy link

Nice work @hwibaski !! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raon0211 raon0211 raon0211 approved these changes

@dayongkr dayongkr Awaiting requested review from dayongkr dayongkr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add defaultsDeep to compat package
3 participants
@hwibaski @raon0211 @injae-kim