receive: use filter on receive diff #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
AkihiroSuda
approved these changes
Oct 8, 2019
tiborvass
reviewed
Oct 9, 2019
| rmdir = f1.path + string(os.PathSeparator) | ||
| } else if rmdir != "" { | ||
| rmdir = "" | ||
| } | ||
| f = f2.f | ||
| f = f2.stat |
There was a problem hiding this comment.
@tonistiigi can you explain why sometimes the original f2 is used and at other times the f2copy copy is used?
There was a problem hiding this comment.
because sometimes we need the filtered and sometimes not. checks are with filter but we pass the original to the callback.
tiborvass
approved these changes
Oct 18, 2019
thaJeztah
added a commit
to thaJeztah/buildkit
that referenced
this pull request
Jan 8, 2020
full diff: tonistiigi/fsutil@3d2716d...0f039a0 - tonistiigi/fsutil#68 fix gocrypto commit - tonistiigi/fsutil#69 receive: use filter on receive diff - prevents incremental transfers with userns because the metadata on disk is always different than the one being transferred. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/buildkit
that referenced
this pull request
Jan 8, 2020
full diff: tonistiigi/fsutil@3d2716d...0f039a0 - tonistiigi/fsutil#68 fix gocrypto commit - tonistiigi/fsutil#69 receive: use filter on receive diff - prevents incremental transfers with userns because the metadata on disk is always different than the one being transferred. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Jan 13, 2020
full diff: tonistiigi/fsutil@3bbb99c...0f039a0 - tonistiigi/fsutil#66 copy: add fast copy path for darwin - tonistiigi/fsutil#67 Treat Unix sockets as regular files - relates to moby/buildkit#1144 Fix socket handling - tonistiigi/fsutil#68 fix gocrypto commit - tonistiigi/fsutil#69 receive: use filter on receive diff - prevents incremental transfers with userns because the metadata on disk is always different than the one being transferred. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Jan 13, 2020
full diff: tonistiigi/fsutil@3bbb99c...0f039a0 - tonistiigi/fsutil#66 copy: add fast copy path for darwin - tonistiigi/fsutil#67 Treat Unix sockets as regular files - relates to moby/buildkit#1144 Fix socket handling - tonistiigi/fsutil#68 fix gocrypto commit - tonistiigi/fsutil#69 receive: use filter on receive diff - prevents incremental transfers with userns because the metadata on disk is always different than the one being transferred. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 94a8c8b3c09540497f6fb7a3d40de80610c920ac Component: engine
thaJeztah
added a commit
to thaJeztah/buildkit
that referenced
this pull request
Jan 16, 2020
full diff: tonistiigi/fsutil@3d2716d...0f039a0 - tonistiigi/fsutil#68 fix gocrypto commit - tonistiigi/fsutil#69 receive: use filter on receive diff - prevents incremental transfers with userns because the metadata on disk is always different than the one being transferred. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 6a06e8b) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Feb 12, 2020
full diff: tonistiigi/fsutil@7f9f923...0f039a0 - tonistiigi/fsutil#69 receive: use filter on receive diff - prevents incremental transfers with userns because the metadata on disk is always different than the one being transferred. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Feb 12, 2020
full diff: tonistiigi/fsutil@7f9f923...0f039a0 - tonistiigi/fsutil#69 receive: use filter on receive diff - prevents incremental transfers with userns because the metadata on disk is always different than the one being transferred. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Feb 13, 2020
full diff: tonistiigi/fsutil@7f9f923...0f039a0 - tonistiigi/fsutil#69 receive: use filter on receive diff - prevents incremental transfers with userns because the metadata on disk is always different than the one being transferred. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 0fe7190d04156b6e2103695f23b1b28c73205023 Component: cli
eiffel-fl
pushed a commit
to eiffel-fl/cli
that referenced
this pull request
Jul 28, 2020
full diff: tonistiigi/fsutil@7f9f923...0f039a0 - tonistiigi/fsutil#69 receive: use filter on receive diff - prevents incremental transfers with userns because the metadata on disk is always different than the one being transferred. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure filter is taken into an account when comparing existing files in the receiver. This issue prevents incremental transfers with userns because the metadata on disk is always different than the one being transferred.