Various fixes from lmms #6
Conversation
tap_pinknoise.c
Outdated
| @@ -236,9 +236,6 @@ _init() { | |||
| (LADSPA_Descriptor *)malloc(sizeof(LADSPA_Descriptor))) == NULL) | |||
| exit(1); | |||
|
|
|||
| /* initialize RNG */ | |||
| srand(time(0)); | |||
There was a problem hiding this comment.
What's wrong with this, and how is the RNG supposed to be initialized without it?
There was a problem hiding this comment.
@tomszilagyi you're completely correct, this should not be removed from the plugin. It appears these lines conflict with the use of srand() in the parent application and allowing them to be called here has an adverse affect on the parent. Would you be ok with us adding some pre-compiler flags to allow us to turn this off for a use-case that has already called srand() prior to loading the plugin?
There was a problem hiding this comment.
Yes, that would be a reasonably good way to handle it.
There was a problem hiding this comment.
Thanks. Proposed via b3978dc, downstream logic proposed here tresf/lmms@c444760.
|
Thanks for the fixes! |
First, thanks for the plugins! And second, hi from LMMS!
We've been bundling the
tap-pluginsfor quite some time but we've been pretty bad about sending our patches back.We have an initiative to move all of our plugin code back to the upstream maintainers, so that this won't happen anymore. :) I hope this PR is well received.
The changes are pretty small, so I've placed them all into one commit.
I did not author these changes, however they are needed (especially the constructors/destructors) to use an upstream source mirror. We support several build systems including Linux, BSD, Apple and Windows (gcc and clang for now), so patches are driven primary by 1. Making them work and 2. Compiler warnings. Reviewing the changes, I can observe one that appears to be a styling change as well. I hope this is OK. I can move that to a separate PR if needed.
The downstream documented fixes that we have are (should jump to relevant snippet):
Any changes needed, please let me know. I'd also be willing to split commits and/or PRs if that makes it easier.